Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 01 Apr 2014 14:33:23 -0700] rev 20928
localrepo: move the getlocalbundle method in changegroup module
This is a gratuitous code move aimed at reducing the localrepo bloatness.
The method had 3 callers total, far too few for being kept in local repo.
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 01 Apr 2014 14:25:03 -0700] rev 20927
localrepo: move the changegroupsubset method in changegroup module
This is a gratuitous code move aimed at reducing the localrepo bloatness.
The method had few callers, not enough to be kept in local repo.
The peer API remains unchanged.
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 01 Apr 2014 14:13:34 -0700] rev 20926
localrepo: move the changegroupinfo method in changegroup module
This is a gratuitous code move aimed at reducing the localrepo bloatness.
The method had a single caller... already in this changegroup module.
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 01 Apr 2014 13:59:55 -0700] rev 20925
localrepo: move the _changegroupsubset method in changegroup module
This is a gratuitous code move aimed at reducing the localrepo bloatness.
The method had 3 callers total, far too few for being kept in local repo.
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 01 Apr 2014 13:45:48 -0700] rev 20924
push: pass a `pushoperation` object to localrepo.checkpush
The `pushoperation` object contains strictly more data the arguments currently
passed to `localrepo.checkpush` we pass the new object instead. This function is
used by MQ to abort push that includes MQ changesets.
Note: extension that may use this function will have to align.
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:43:30 -0700] rev 20923
wireproto: use decorator for the ubundle command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:43:11 -0700] rev 20922
wireproto: use decorator for the stream command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:42:55 -0700] rev 20921
wireproto: use decorator for the pushkey command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:42:38 -0700] rev 20920
wireproto: use decorator for the lookup command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:42:21 -0700] rev 20919
wireproto: use decorator for the listkeys command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:42:06 -0700] rev 20918
wireproto: use decorator for the known command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:40:44 -0700] rev 20917
wireproto: use decorator for the hello command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:40:31 -0700] rev 20916
wireproto: use decorator for the heads command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:40:07 -0700] rev 20915
wireproto: use decorator for the getbundle command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:39:06 -0700] rev 20914
wireproto: use decorator for the debugwireargs command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:38:40 -0700] rev 20913
wireproto: use decorator for the changegroupsubset command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:38:19 -0700] rev 20912
wireproto: use decorator for the changegroup command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:37:28 -0700] rev 20911
wireproto: use decorator for the capabilities command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:37:02 -0700] rev 20910
wireproto: use decorator for the branches command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:36:41 -0700] rev 20909
wireproto: use decorator for the branchmap command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:36:05 -0700] rev 20908
wireproto: use decorator for the between command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:35:36 -0700] rev 20907
wireproto: use decorator for the batch command
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:30:11 -0700] rev 20906
wireproto: add decorator for wire protocol command
Move move in the same direction we took for command line commands. each wire
protocol function will be decorated with its name and arguments.
Beside beside easier to read, this open the road to easily adding more metadata
(like security level or return type)
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 14:24:13 -0700] rev 20905
wireproto: drop the _decompress method in favor a new call type
We already have multiple call function for multiple return type. The
`_decompress` function is only used for http and seems like a layer violation.
We drop it in favor of a new call type dedicated to "stream that may be useful to
compress".
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 12:29:34 -0700] rev 20904
wireproto: document protocol specific function of wirepeer
Those function are explicitly declared and documented now.
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 11:10:33 -0700] rev 20903
wireproto: introduce an abstractserverproto class
sshserver and webproto now inherit from an abstractserverproto class. This class
is introduced for documentation purpose.
Pierre-Yves David <pierre-yves.david@fb.com> [Fri, 28 Mar 2014 11:37:42 -0700] rev 20902
wireproto: document possible return type
The wireprotocole command use a small set of class as return value. We document
the meaning of each of them.
AS my knowledge of wire protocol is fairly shallow, the documentation can
probably use improvement. But this is a better than nothing.
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 01 Apr 2014 18:56:19 -0700] rev 20901
pull: add a set of steps that remain to be done during the pull
With bundle2 we'll slowly move current steps into a single bundle2 building and
call (changegroup, phases, obsmarkers, bookmarks). But we need to keep the
old methods around for servers that do not support bundle2. So we introduce
this set of steps that remains to be done.
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 01 Apr 2014 17:35:25 -0700] rev 20900
pull: put discovery step in its own function
The discovery is a full step that will grow to contain more than changesets. We
set it in its own function like all other steps.
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 01 Apr 2014 17:28:21 -0700] rev 20899
pull: move the cgresult logic in _pullchangeset
Logical follow up of the previous changeset. The `_pullchangeset` is now
responsible of setting the `pullop.cgresult`.