crecord: re-center display in interactive curses commit on pageup/down A long-standing issue in the crecord (interactive curses commit interface) is that using PageUp/Down to move along longer-than current screen size chunks would "lose" the cursor and not properly re-center. There has been self.recenterdisplayedarea() to do that, but it has not been in use for some reason. Add calls to the appropriate uparrowshiftevent() and downarrowshiftevent() methods to fix this.

tests: in test-split.t, save a "clean" copy of pre-split repo for later use Differential Revision: https://phab.mercurial-scm.org/D2015

tests: use progress helper With this commit, the only in-tree caller of ui.progress() is scmutil.progress(). That means that we could deprecate it. It also means that we can considering inlining it in scmutil.progress. Differential Revision: https://phab.mercurial-scm.org/D3812

changegroup: use progress helper Although it looks like this code was micro-optimized, I could not measure any slow-down. Differential Revision: https://phab.mercurial-scm.org/D3811

synthrepo: close progress topics Differential Revision: https://phab.mercurial-scm.org/D3810

synthrepo: use progress helper Differential Revision: https://phab.mercurial-scm.org/D3809

largefiles: use progress helper Differential Revision: https://phab.mercurial-scm.org/D3808

convert: use progress helper Differential Revision: https://phab.mercurial-scm.org/D3807

lfs: use progess helper Differential Revision: https://phab.mercurial-scm.org/D3806

relink: use progress helper This doesn't use progress.increment() because progress output is skipped for some positions (so we may end up calling "update(0), update(2), update(7)", or similar). Differential Revision: https://phab.mercurial-scm.org/D3805

patchbomb: use progress helper Differential Revision: https://phab.mercurial-scm.org/D3804

patchbomb: don't close unused progress topic The "writing" topic has not been used since 1830d0cc4bc1 (patchbomb: minor refactoring of mbox functionality, preparing for move, 2011-11-23). Differential Revision: https://phab.mercurial-scm.org/D3803

churn: use progess helper Differential Revision: https://phab.mercurial-scm.org/D3802

treediscovery: use progress helper Differential Revision: https://phab.mercurial-scm.org/D3801

upgrade: use progress helper A minor side-effect is that we no longer print the progress at 0 (and that we don't re-print it at its current value when starting the next manifest/file). Differential Revision: https://phab.mercurial-scm.org/D3800

upgrade: close progress after each revlog IIUC, one is supposed to close each progress topic before strarting a new one. Otherwise the topics are considered nested, which we don't want here. Differential Revision: https://phab.mercurial-scm.org/D3799

verify: use progress helper Differential Revision: https://phab.mercurial-scm.org/D3798

verify: use progress helper for subdirectory progress I also reworded a variable to make it clearer that it's only used for subdirectories. Differential Revision: https://phab.mercurial-scm.org/D3797

similar: use progress helper A side-effect is that progress is now reported as 1 *before* we start checking the first file. That seems to be how we do it in most places. Also, the right topic is now closed. Differential Revision: https://phab.mercurial-scm.org/D3796

repair: use progress helper Differential Revision: https://phab.mercurial-scm.org/D3795

httpconnection: use progress helper Differential Revision: https://phab.mercurial-scm.org/D3794

py3: byte-stringify literals in contrib/phabricator.py as example Transformed by contrib/byteify-strings.py and adjusted exceeded lines manually. Some of b''s would be wrong as the phabriactor extension has to work with JSON data. # skip-blame just many b prefixes

byteify-strings: remove superfluous "if True" block

byteify-strings: try to preserve column alignment

byteify-strings: do not rewrite system string literals to u'' It would make things worse on Python 2 because unicode processing is generally slower than byte string. We should just leave system strings unmodified.

byteify-strings: do not rewrite iteritems() and itervalues() by default We can't do that automatically due to performance concerns.

byteify-strings: drop import-line hack This is ugly, and valid only for Python 3. We'll need to find a different way if we want to get rid of the code transformer at all.

byteify-strings: add --inplace option to write back result

byteify-strings: add basic command interface

byteify-strings: fork py3 code transformer to make it a standalone command I'm thinking of making a one-off s/''/b''/g change for overall codebase to make linter happy. We could do that without maintaining the script, but I think it will be somewhat useful for extension authors. So it is in contrib.