Mon, 18 May 2015 16:22:15 -0500 patchbomb: stop explicit import required by Python 2.4
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:22:15 -0500] rev 25202
patchbomb: stop explicit import required by Python 2.4 Ding Dong, the witch is dead!
Mon, 18 May 2015 16:20:12 -0500 pager: drop python 2.4 hack around subprocess
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:20:12 -0500] rev 25201
pager: drop python 2.4 hack around subprocess Farewell, we do not need you anymore.
Mon, 18 May 2015 16:18:18 -0500 check-code: drop ban of 'val if cond else otherval' construct
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:18:18 -0500] rev 25200
check-code: drop ban of 'val if cond else otherval' construct We now have access to this horrible but less bad than 'cond and val or otherval' syntax.
Mon, 18 May 2015 16:30:24 -0500 check-code: entirely drop the 'non-py24.py' file from the test
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:30:24 -0500] rev 25199
check-code: entirely drop the 'non-py24.py' file from the test There are no Python 2.4 related errors remaining.
Mon, 18 May 2015 16:11:44 -0500 check-code: drop the 'format' built-in
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:11:44 -0500] rev 25198
check-code: drop the 'format' built-in I'm not clear what it is doing, but one who knows what it is about can now make use of it.
Mon, 18 May 2015 16:09:05 -0500 check-code: drop ban of str.format
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:09:05 -0500] rev 25197
check-code: drop ban of str.format After discussion with Augie and Matt, we are fine with it being introduced in the code base.
(0) -10000 -3000 -1000 -300 -100 -30 -10 -6 +6 +10 +30 +100 +300 +1000 +3000 +10000 tip