wireprotoserver: remove sshserver.getarg()
AFAICT the last consumer of this helper method was removed by
d054cc5c7737 in 2010.
Differential Revision: https://phab.mercurial-scm.org/D1987
wireprotoserver: remove lock references
AFAICT sshserver.lock is unused. The last caller of it disappeared
in
9f6e0e7ef828 ~18 months ago as part of removing code to support
ancient wire protocol commands. Let's remove some dead code.
Differential Revision: https://phab.mercurial-scm.org/D1986
wireprotoserver: remove support for do_<command> handlers (API)
Old versions of wire protocol handlers relied on methods
named do_<command> to handle wire protocol commands. The last
definition of these methods on sshserver was removed by
9f6e0e7ef828 ~2 years ago. I think it's time to not support this
mechanism for defining command handlers.
.. api::
sshserver no longers looks for wire protocol command handlers
in methods named do_<command>. Use @wireproto.wireprotocommand
to declare wire protocol command handler functions.
Differential Revision: https://phab.mercurial-scm.org/D1985
wireprotoserver: make attributes private
These aren't part of the protocol interface. So they should be
_ prefixed.
Differential Revision: https://phab.mercurial-scm.org/D1984
wireprotoserver: remove unused response attribute
I think the last use of this attribute was removed by
2f8adc60e013
in 2010.
Differential Revision: https://phab.mercurial-scm.org/D1983
wireprotoserver: rename p to proto
To aid readability. And to make it easier to search the code base
for protocol instances.
Differential Revision: https://phab.mercurial-scm.org/D1982
wireprotoserver: add some blank lines between methods
Let's make this file slightly easier to read.
Differential Revision: https://phab.mercurial-scm.org/D1981
tests: start a set of unit tests for mdiff.py, starting with splitnewlines
I want to optimize splitnewlines, so writing tests seems prudent.
Differential Revision: https://phab.mercurial-scm.org/D1972
# no-check-commit because of test_ funciton
perf: add a perfunidiff command for benchmarking unified diff speed
Differential Revision: https://phab.mercurial-scm.org/D1971
wireprotoserver: move abstractserverproto class from wireproto
Let's have the interface live next to things that define it.
Differential Revision: https://phab.mercurial-scm.org/D1969