path-suboption: use str for "_pushloc" suboptions That second argument refer to an attribute and do not needs to be bytes.

path-suboption: use str for "pushrev" suboptions That second argument refer to an attribute and do not needs to be bytes.

path-suboption: use str for "bookmarks_mode" suboptions That second argument refer to an attribute and do not needs to be bytes.

path-suboption: use str for "delta_reuse_policy" suboptions That second argument refer to an attribute and do not needs to be bytes.

path-suboption: use str for "multi_urls" path suboptions That second argument refer to an attribute and do not needs to be bytes.

convert: use sysstr to check for attribute presence We do not need bytes here.

mq: use sysstr to check for attribute access We do not need bytes here.

lfs: use sysstr to check for attribute presence We do not need bytes here.

mq: use sysstr to check for attribute presence We do not need bytes here.

relink: use sysstr to check for attribute presence We do not need bytes here.

ui: use sysstr to check for attribute presence We do not need bytes here.

remotefilelog: use sysstr to access for attributes We do not need bytes here.

hgwebmod: use sysstr to check for attribute presence We do not need bytes here.

remotefilelog: use sysstr to check for attribute presence We do not need bytes here.

extensions: use sysstr to check for attribute presence We do not need bytes here.

bundle2: use sysstr to check for attribute presence We do not need bytes here.

largefile: use sysstr to check for attribute presence in `hgsubrepoarchive` We do not need bytes here.

largefile: use sysstr to check for attribute presence in `openstore` We do not need bytes here.

largefile: use sysstr to check for attribute presence in `rebase` wrapping We do not need bytes here.

largefile: use sysstr to check for attribute presence in `getstatuswriter` We do not need bytes here.

run-tests: detect HGWITHRUSTEXT value Without this, some manual check in tests/test-dirstate.t could get confused by the lack of `rust` in module policy and break the test.

convert: stabilize subversion date sorter In case of tie, this provides unstable result on my system. So I am adding a couple of tie breaker to fix the test.

rhg: allow setting defaults.cmd to an empty string This is used by at least one hg UI to prevent defaults from affecting the command: https://github.com/emacs-mirror/emacs/blob/b71beb7ae7c60a5c5af608420d28fdda5265a264/lisp/vc/vc-hg.el#L245 Let's let it work.

uncommit: migrate `opts` to native kwargs

split: migrate `opts` to native kwargs

releasenotes: migrate `opts` to native kwargs

narrow: hoist a variable to a higher level to avoid use-before-init warning In practice, this shouldn't generate an IOError, so there wouldn't have been a problem. But PyCharm didn't know that.

narrow: migrate `opts` to native kwargs

largefiles: migrate `opts` to native kwargs

keyword: migrate `opts` to native kwargs

gpg: use a context manager to write `.hgsigs`

gpg: migrate `opts` to native kwargs

fetch: migrate `opts` to native kwargs

fastexport: migrate `opts` to native kwargs

closehead: wrap transaction handling in a context manager

closehead: migrate `opts` to native kwargs

churn: migrate `opts` to native kwargs

children: migrate `opts` to native kwargs

automv: migrate `opts` to native kwargs

absorb: migrate `opts` to native kwargs

transaction: fix __repr__() and make the default name bytes This likely was always wrong on py3, since going back to aff5996f3043, these were added as a r-strings. Callers seem to always be supplying bytes, which makes the `b'/'.join(...)` part OK, but then bytes can't be interpolated into str with "%s", so it wouldn't have worked in either case.

rhg: support rhg files [FILE] This comes mostly for free after the rhg status [FILE] implementation.

rhg: support "status FILE" This change adds a new [file] argument to rhg status, parses them as patterns, canonicalizes the paths, and constructs a new PatternMatcher to intersect with the existing matcher being passed to the status implementation. We also make filepatterns a public module so we can access the pattern-parsing functionality we need from commands/status.rs.

rust-matchers: add PatternMatcher This should match the behavior of the Python patternmatcher. We need this for status [FILES] support.

rust-status: only visit parts of the tree requested by the matcher This is an optimization that the matcher is designed to support, but we weren't doing it until now. This is primarily relevant for supporting "hg status [FILES]", where this optimization is crucial for getting good performance (without this optimization, that command will still scan the entire tree, and just filter it down after the fact). When this optimization fires we have to return false from traverse_fs_directory_and_dirstate, representing that that part of the tree *might* have new files which we didn't see because we skipped parts of it. This only affects the cached result of the status, and is necessary to make future status operations (which might use a different matcher) work properly.

rust-status: error on non-existent files in file_set file_set here consists of the files that were explicitly specified on the command line. Erroring on them matches the behavior of Python status.

rust-status: explicitly track bad file types Before this, we silently skipped bad file types. Now, we check to see if a path is an exact_match in our matcher, and if so, print an error for it, and only then do we skip it. A path will be an exact match when it's specified as an explicit command line argument, and this error-printing behavior is necessary for compatibility with Python status.

rust: de-hardcode glob_suffix We're adding patternmatcher in a subsequent commit, and this needs needs to be different for includematcher and patternmatcher.