py3: catch PermissionError instead of checking errno == EPERM

py3: catch PermissionError instead of checking errno == EACCES

py3: catch FileNotFoundError instead of checking errno == ENOENT

py3: catch FileExistsError instead of checking errno == EEXIST

py3: catch BrokenPipeError instead of checking errno == EPIPE

py3: catch ChildProcessError instead of checking errno == ECHILD

py3: remove retry on EINTR errno Since the implementation of PEP 475 (Python 3.5), Python retries system calls failing with EINTR. Therefore we don’t need the logic that retries it in Python code.

py3: stop catching TypeError that was raised on Python 2

py3: use `x.hex()` instead of `pycompat.sysstr(node.hex(x))`

tests: assume that `raw` attribute is present on original socket file object It seems like the original socket file object is always an io.BufferedIO instance. If not, the code will fail and we should try harder to get the socket object (e.g. if the original socket file object is unbuffered, we can get the `_sock` attribute directly from it).

tests: constant-fold a `pycompat.ispy3` in testlib/badserverext.py

tests: remove Python 2 special cases in test-stdio.py

py3: remove dead code to make file descriptors non-inheritable On Python 3, file descriptors are already non-inheritable by default.

py3: remove hack that removed flush argument from print() calls on Python 2

py3: remove long() compatibility code

zeroconf: constant-fold a `pycompat.ispy3` I’ve checked that both bytes and str gets passed as the `name` parameter, so the rest of the condition is still required. Because there aren’t really any tests for the extensions, I didn’t want to refactor it to pass a single type.

py3: remove conditional to import collections.abc.MutableMapping

py3: remove dead code to open file with O_CLOEXEC on Python 2 The O_CLOEXEC flag is passed by default on Python 3.

py3: don’t encode node.bin() argument It accepts str and bytes.

convert: inline Python 3 variant of url2pathname_like_subversion()

py3: constant-fold some `pycompat.ispy3`

py3: use `zip()` instead of trying to use `itertools.izip()`

py3: replace mention of “xrange” in docstring by “range”

py3: remove xrange() compatibility code Some code used its own xrange() compatibility code instead of pycompat.xrange().

py3: replace `pycompat.xrange` by `range`

hgweb: remove dead code handling UnicodeDecodeError I’m quite confident that the error can’t happen on Python 3, as the main motivation for separating bytes and str in Python 3 was to avoid this class of errors.

cleanup: remove import of already imported module

cleanup: rename some functions to avoid redefinitions

thirdparty: remove Python 2-specific selectors2 copy The selectors module was added in Python 3.4. Because we require Python 3.6, it will always be available. Therefore the selectors2 module is not imported. I’ve verified that the selectors2-specific workaround in commandserver.py is not necessary with the selectors module from the standard library. It returns an empty list if timeout was exceeded. The pytype directive was needed to silence the following error: File "/tmp/mercurial-ci/mercurial/worker.py", line 299, in _posixworker: No attribute 'close' on int [attribute-error] In Union[_typeshed.HasFileno, int] File "/tmp/mercurial-ci/mercurial/worker.py", line 299, in _posixworker: No attribute 'close' on _typeshed.HasFileno [attribute-error] In Union[_typeshed.HasFileno, int]

branching: merge stable into default