Jun Wu <quark@fb.com> [Mon, 02 Oct 2017 18:22:43 -0700] rev 34444
test-logtoprocess: make it compatible with chg
chg runs more commands and outputs more lines. This patch matches them.
Differential Revision: https://phab.mercurial-scm.org/D914
Saurabh Singh <singhsrb@fb.com> [Tue, 03 Oct 2017 11:10:03 -0700] rev 34443
test-globalopts: make the test compatible with chg
The test fails when run with the '--chg' option. Therefore, this
commit modifies the test to make it compatible with chg.
Test Plan:
Ran 'test-globalopts.t' with and without the '--chg' option.
Differential Revision: https://phab.mercurial-scm.org/D913
Jun Wu <quark@fb.com> [Mon, 02 Oct 2017 16:11:57 -0700] rev 34442
test-pager: make it compatible with chg
chg's runpager implementation is different. It behaves differently for the
"shell=False, command not found" case.
Differential Revision: https://phab.mercurial-scm.org/D911
Gregory Szorc <gregory.szorc@gmail.com> [Mon, 02 Oct 2017 11:03:53 +0100] rev 34441
changelog: use a Factory for default value for files
The default value is compiled into the generated type. This means
that default values are shared between instances. For immutable types
like bool, str, int, and tuple, this is fine. But for mutable types
like list and dict, we need to use attr.Factory() to instantiate a
new instance of the default for each object.
Differential Revision: https://phab.mercurial-scm.org/D901
Gregory Szorc <gregory.szorc@gmail.com> [Mon, 02 Oct 2017 19:28:41 +0100] rev 34440
cext: wrap before brace for functions
This is our prevailing style.
Differential Revision: https://phab.mercurial-scm.org/D910
Gregory Szorc <gregory.szorc@gmail.com> [Mon, 02 Oct 2017 19:09:52 +0100] rev 34439
cext: put case statements on separate line
This seems to be the prevailing style, even though it is a bit more
verbose for very simple switch statements.
Differential Revision: https://phab.mercurial-scm.org/D909
Gregory Szorc <gregory.szorc@gmail.com> [Mon, 02 Oct 2017 19:06:00 +0100] rev 34438
cext: reorder #include
We mostly abide by this style.
In one case, a blank line was inserted to prevent a local
`#include "file"` from coming before a `#include <file>`.
Differential Revision: https://phab.mercurial-scm.org/D908
Gregory Szorc <gregory.szorc@gmail.com> [Mon, 02 Oct 2017 19:02:43 +0100] rev 34437
cext: move braces for control statements to same line
This seems to be the prevailing style in the code by a wide margin.
Differential Revision: https://phab.mercurial-scm.org/D907
Saurabh Singh <singhsrb@fb.com> [Mon, 02 Oct 2017 19:17:04 +0100] rev 34436
registrar: fixing typo in comment
I was just going through the module and noticed the typo. This commit
fixes 'onfalure' -> 'onfailure'.
Differential Revision: https://phab.mercurial-scm.org/D906
Alex Gaynor <agaynor@mozilla.com> [Fri, 29 Sep 2017 15:49:20 +0000] rev 34435
style: never put multiple statements on one line
Differential Revision: https://phab.mercurial-scm.org/D905