changegroup: close progress in same function as it's started
changegroup.group() and changegroup.generatefiles() both currently
start progress (with topic "bundling"), but changegroup.generate()
closes the topic. Move the closing to the functions that start the
topic, so it's easier to see where the topic is started and closed.
This completes a move that seems to have been started in
0b564cf359a7
(bundle-ng: move progress handling out of the linkrev callback,
2013-05-10).
changegroup: don't reuse 'mfest' variable for different type
We have a variable 'mfest' that's first a manifest nodeid and then a
manifest. Let's make it clearer by using separate variables for the
two uses.
changegroup: rename 'mf' to 'ml' to match 'cl', since it's a revlog
The 'mf' variable is a manifest revlog, not a manifest, so let's
rename it accordingly. We already call the changelog variable 'cl', so
'ml' seems appropriate.
changegroup: document that 'source' parameter exists for extensions
The 'source' parameter passed to generatefiles() is unused by the
method itself, but Durham says it is used by an extension.
changegroup: removed unused 'source' parameter from prune()
The parameter has been unused since it was introduced in
6ea1f858efd9
(bundle: refactor changegroup prune to be its own function,
2013-05-30), and Durham says it is not used by his extension either.
Added signature for changeset
8cc6036bca53
Added tag 3.4 for changeset
8cc6036bca53
tests: make tests with temporary environment setting portable
With "dash" (as "/bin/sh" on Debian GNU/Linux), command execution in
"ENV=val foo bar" style doesn't work as expect in test script files,
if "foo" is user-defined function: it works fine, if "foo" is existing
commands like "hg".
09049042ab99 introduced tests for HGPLAIN and HGPLAINEXCEPT into
test-revset.t, and all of them are in such style.
This patch doesn't:
- add explicit unsetting for HGPLAIN and HGPLAINEXCEPT
they are already introduced by
09049042ab99
- write assignment and exporting in one line
"ENV=val; export ENV" for two or more environment variables in one
line causes failure of test-check-code-hg.t: it is recognized as
"don't export and assign at once" unfortunately.