Mathias De Mare <mathias.de_mare@nokia.com> [Wed, 11 Nov 2020 20:44:45 +0100] rev 45935
packaging: enable rust extensions on centos
Test on CentOS 7, repository with ~170000 tracked files,
no untracked files:
10 runs with this enabled:
-- Run #0 time: 0.
6519973278045654
-- Run #1 time: 0.
6933724880218506
-- Run #2 time: 0.
7512078285217285
-- Run #3 time: 0.
7517638206481934
-- Run #4 time: 0.
5966529846191406
-- Run #5 time: 0.
5960886478424072
-- Run #6 time: 0.
5940573215484619
-- Run #7 time: 0.
5963726043701172
-- Run #8 time: 0.
6048009395599365
-- Run #9 time: 0.
603604793548584
10 runs without this enabled:
-- Run #0 time: 2.
127584457397461
-- Run #1 time: 2.
066192865371704
-- Run #2 time: 2.
0831892490386963
-- Run #3 time: 2.
077716588973999
-- Run #4 time: 2.
07608962059021
-- Run #5 time: 2.
072899341583252
-- Run #6 time: 2.
094369888305664
-- Run #7 time: 2.
067504644393921
-- Run #8 time: 2.
069610834121704
-- Run #9 time: 2.
0567898750305176
Differential Revision: https://phab.mercurial-scm.org/D9294
Matt Harbison <matt_harbison@yahoo.com> [Sat, 21 Nov 2020 22:46:09 -0500] rev 45934
tests: use `testrepohg` in one more place in test-check-code.t
This is already used elsewhere in the test to access the current hg repo, and
avoids an error about the unknown `revlog-compression-zstd` when C extensions
aren't built. The only other such error is in test-check-interfaces.py, but I
don't see a way to avoid it other than to create an empty scratch repo.
Differential Revision: https://phab.mercurial-scm.org/D9364
Matt Harbison <matt_harbison@yahoo.com> [Sat, 21 Nov 2020 16:20:49 -0500] rev 45933
setup: copy pythonXY.dll next to the hg.exe wrapper when building
This avoids the problem of having the newly built binary complaining that it
can't find the DLL. There is an option in the python.org installer to add the
python install to PATH (which defaulted to "on" with py2, and therefore was not
an issue up to this point), but that makes switching between python versions
harder.
This shouldn't be an issue with the PyOxidizer binary, but that current has
issues running some of the tests, and took noticeably longer to build last time
I tried it.
Differential Revision: https://phab.mercurial-scm.org/D9362
Matt Harbison <matt_harbison@yahoo.com> [Sun, 22 Nov 2020 15:07:09 -0500] rev 45932
exthelper: update the examples to be python3 complaint
Differential Revision: https://phab.mercurial-scm.org/D9368
Matt Harbison <matt_harbison@yahoo.com> [Sun, 22 Nov 2020 14:55:40 -0500] rev 45931
helptext: byteify extensions examples
Make it easier on the copy/paste crowd. I haven't looked at the other help text
to see if there are other instances; I was just looking to confirm `buglink` is
meant to be bytes and this popped up along with the code.
Differential Revision: https://phab.mercurial-scm.org/D9367
Matt Harbison <matt_harbison@yahoo.com> [Sun, 22 Nov 2020 14:53:17 -0500] rev 45930
helptext: fix sentence in extensions documentation
Differential Revision: https://phab.mercurial-scm.org/D9366
Matt Harbison <matt_harbison@yahoo.com> [Mon, 23 Nov 2020 11:47:06 -0500] rev 45929
ui: ensure `getpass()` returns bytes
Previously, this could return either bytes or str. I'm not sure which direction
we should go in, but since the input is bytes, I guess bytes makes sense as
output. `debuguigetpass` crashed because it assumed bytes would be returned,
`sslcontext.load_cert_chain()` is happy with bytes or str if the type info in
PyCharm is correct, and `smtplib.SMTP.login()` wants str.
I couldn't figure out how to test this, because the test stalls for input with
`echo test | hg debuguigetpass --config ui.interactive=1`, likely because it
drains stdin before prompting. The custom input reading with `ui.nontty=1` does
not.
I'm also a bit concerned with all of this encoding/decoding. The existing code
in the mail module uses `encoding.strfromlocal()`, but the username and password
are ascii encoded/decoded in `mercurial.url.passwordmgr.find_user_password()`
with `pycompat.{str,bytes}url()`. I'm not sure if this inconsistency could
cause subtle compatability issues.
Differential Revision: https://phab.mercurial-scm.org/D9375