Mon, 04 May 2009 18:04:41 +0900 inotify: inotify.server.walk() simplify control flow
Nicolas Dumazet <nicdumz.commits@gmail.com> [Mon, 04 May 2009 18:04:41 +0900] rev 8325
inotify: inotify.server.walk() simplify control flow
Mon, 04 May 2009 17:58:26 +0900 inotify: inotify.server.walk*() remove unnecessary var
Nicolas Dumazet <nicdumz.commits@gmail.com> [Mon, 04 May 2009 17:58:26 +0900] rev 8324
inotify: inotify.server.walk*() remove unnecessary var Remove hginside var and the test it relates to: not( top or not hginside ) == (not top) and hginside, so the only case when nothing will be yielded is when hginside is True and top is False. Because of the returns placed upstream, this case will not happen anymore. We can then safely remove hginside and the (if)s
Mon, 04 May 2009 17:17:03 +0900 inotify: inotify.server.walk*() cleanup
Nicolas Dumazet <nicdumz.commits@gmail.com> [Mon, 04 May 2009 17:17:03 +0900] rev 8323
inotify: inotify.server.walk*() cleanup When not in root repo, if we meet a .hg, bail out. break was used, but return can be safely used instead: if we go through break then (top or not hginside) == False -> nothing is done after the for loop
Mon, 04 May 2009 17:11:49 +0900 inotify: inotify.server.walkrepodirs() simplify walking
Nicolas Dumazet <nicdumz.commits@gmail.com> [Mon, 04 May 2009 17:11:49 +0900] rev 8322
inotify: inotify.server.walkrepodirs() simplify walking Do not 'yield tuple, boolean' to filter later on the boolean. Test the boolean first, and yield tuple only if needed.
Mon, 04 May 2009 17:06:59 +0900 inotify: inotify.server.walkrepodirs() simplify
Nicolas Dumazet <nicdumz.commits@gmail.com> [Mon, 04 May 2009 17:06:59 +0900] rev 8321
inotify: inotify.server.walkrepodirs() simplify compute string concatenation only once
Mon, 04 May 2009 16:57:52 +0900 inotify: inotify.server.walk() simplify algorithm
Nicolas Dumazet <nicdumz.commits@gmail.com> [Mon, 04 May 2009 16:57:52 +0900] rev 8320
inotify: inotify.server.walk() simplify algorithm Do not yield (bool, tuple) in a subfunction and check later: 'if not bool: yield tuple'. Instead simplify so the tuple doesnt get yielded on the first time, to avoid systematic checks.
Mon, 04 May 2009 16:43:28 +0900 inotify: inotify.server.walk cleanups
Nicolas Dumazet <nicdumz.commits@gmail.com> [Mon, 04 May 2009 16:43:28 +0900] rev 8319
inotify: inotify.server.walk cleanups * Removing useless path computation * moving 'reporoot' computation down to the first call to avoid confusion with the parameter used in walkit()
(0) -3000 -1000 -300 -100 -30 -10 -7 +7 +10 +30 +100 +300 +1000 +3000 +10000 +30000 tip