# HG changeset patch # User Martin von Zweigbergk # Date 1449276306 28800 # Node ID 0e5aab543d851b160c346a8c2c3b15e7de275a97 # Parent 0d5fe81320a93bd2656e5a610c6a6169459c9af4 revlog: clarify which revision is added to 'tested' when using cached delta The tested delta revisions are added to the 'tested' set. These are the same revisions we pass to builddelta(). However, in one case, we add builddelta(rev)[3] to the set intead of adding 'rev' itself. In that particular case, that element is the same as the function's input revision (because self._generaldelta is true), so the effect is the same. Still, let's just add the function's input revision to avoid confusing future readers. diff -r 0d5fe81320a9 -r 0e5aab543d85 mercurial/revlog.py --- a/mercurial/revlog.py Fri Dec 04 17:22:26 2015 -0800 +++ b/mercurial/revlog.py Fri Dec 04 16:45:06 2015 -0800 @@ -1428,7 +1428,7 @@ # Assume what we received from the server is a good choice # build delta will reuse the cache candidatedelta = builddelta(cachedelta[0]) - tested.add(candidatedelta[3]) + tested.add(cachedelta[0]) if self._isgooddelta(candidatedelta, textlen): delta = candidatedelta if delta is None and self._generaldelta: