# HG changeset patch # User Martin von Zweigbergk # Date 1519963945 28800 # Node ID 1004fd71810fd280772dd43df91b982e8b2ca14a # Parent 0f3116c08e651e1d0901881d31ebeca63dd91a63 rebase: reduce scope of "dsguard" variables a bit Differential Revision: https://phab.mercurial-scm.org/D2710 diff -r 0f3116c08e65 -r 1004fd71810f hgext/rebase.py --- a/hgext/rebase.py Wed Mar 07 09:46:53 2018 -0800 +++ b/hgext/rebase.py Thu Mar 01 20:12:25 2018 -0800 @@ -565,7 +565,6 @@ editor = cmdutil.getcommiteditor(edit=editopt, editform=editform) revtoreuse = max(self.state) - dsguard = None if self.inmemory: newnode = concludememorynode(repo, revtoreuse, p1, self.external, @@ -575,6 +574,7 @@ keepbranches=self.keepbranchesf, date=self.date, wctx=self.wctx) else: + dsguard = None if ui.configbool('rebase', 'singletransaction'): dsguard = dirstateguard.dirstateguard(repo, 'rebase') with util.acceptintervention(dsguard): @@ -849,7 +849,6 @@ return retcode tr = None - dsguard = None singletr = ui.configbool('rebase', 'singletransaction') if singletr: @@ -861,6 +860,7 @@ with util.acceptintervention(tr): # Same logic for the dirstate guard, except we don't create one when # rebasing in-memory (it's not needed). + dsguard = None if singletr and not inmemory: dsguard = dirstateguard.dirstateguard(repo, 'rebase') with util.acceptintervention(dsguard):