# HG changeset patch
# User Martin von Zweigbergk <martinvonz@google.com>
# Date 1648161689 25200
# Node ID 1138674ecdb8f9896f93f7ae8b6859a437169195
# Parent  455dce344c56a7c67c5100e3a2414158524433b9
templates: make `firstline` filter not keep '\v', '\f' and similar

In b288b4bb8448 (hide some functions behind lambdas, so demandload is
useful., 2006-02-28), `x.splitlines(1)[0]` was replaced by
`x.splitlines(1)[0].rstrip('\r\n')`, i.e. stripping trailing '\r' and
'\n'. Combined with the "truthy" `1` passed to `splitlines()` to get
it to keep line endings, that results in e.g. trailing '\v' (Line
Tabulation) and '\f' (Form Feed) being preserved. I can't see why one
would want that, and I doubt that was the intention; I suspect the
author just didn't think to instead remove the `1` argument. Perhaps
they thought the 1 being passed there - added by themselves in
a7e416bf3c1d (improve templating., 2006-02-27) - was to limit the
number of splits to 1 (i.e. thinking about it as `maxsplit=1` rather
than `keepends=1`).

Differential Revision: https://phab.mercurial-scm.org/D12403

diff -r 455dce344c56 -r 1138674ecdb8 mercurial/templatefilters.py
--- a/mercurial/templatefilters.py	Tue Mar 22 11:22:09 2022 -0400
+++ b/mercurial/templatefilters.py	Thu Mar 24 15:41:29 2022 -0700
@@ -269,7 +269,7 @@
 def firstline(text):
     """Any text. Returns the first line of text."""
     try:
-        return text.splitlines(True)[0].rstrip(b'\r\n')
+        return text.splitlines()[0]
     except IndexError:
         return b''