# HG changeset patch
# User Gregory Szorc <gregory.szorc@gmail.com>
# Date 1534958970 25200
# Node ID 1467b6c27ff929dc9601ad38d2f8bd4a259f08a3
# Parent  4971c97242063e8bf3f8a8496837a0db5fce123f
wireprotov2peer: add TODO about streaming responses

This is a pretty big deficiency in the current implementation.
We don't want to forget about this.

Differential Revision: https://phab.mercurial-scm.org/D4435

diff -r 4971c9724206 -r 1467b6c27ff9 mercurial/wireprotov2peer.py
--- a/mercurial/wireprotov2peer.py	Tue Sep 04 12:36:33 2018 -0400
+++ b/mercurial/wireprotov2peer.py	Wed Aug 22 10:29:30 2018 -0700
@@ -136,6 +136,9 @@
         response = self._responses[frame.requestid]
 
         if action == 'responsedata':
+            # This buffers all data until end of stream is received. This
+            # is bad for performance.
+            # TODO make response data streamable
             response.b.write(meta['data'])
 
             if meta['eos']: