# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1450985534 0
# Node ID 15b06f306c1f4ac13e7eb4ac8b484b43df1e220f
# Parent  d13bcc9fd656f04422e10f3015a04cabd4f822d8
check-code: improve test-check-code error diffs

Whenever check-code finds something wrong, the diffs it
generated were fairly hard to read.

The problem is that check-code before this change
would list files that were white listed using
no- check- code but without a glob marker.

Whereas, the test-check-code.t expected output has
no-che?k-code (glob) in order to avoid having itself
flagged as a file to skip.

Thus, in addition to any lines relating to things you
did wrong, all of the white-listed files are listed as
changed.

There is no reason for things to be this painful.

This change makes the output from check-code.py match
the expected output in test-check-code.t

diff -r d13bcc9fd656 -r 15b06f306c1f contrib/check-code.py
--- a/contrib/check-code.py	Thu Dec 24 10:16:30 2015 -0800
+++ b/contrib/check-code.py	Thu Dec 24 19:32:14 2015 +0000
@@ -478,7 +478,13 @@
                        name, match, f)
             continue
         if "no-" "check-code" in pre:
-            print "Skipping %s it has no-" "check-code" % f
+            # If you're looking at this line, it's because a file has:
+            # no- check- code
+            # but the reason to output skipping is to make life for
+            # tests easier. So, instead of writing it with a normal
+            # spelling, we write it with the expected spelling from
+            # tests/test-check-code.t
+            print "Skipping %s it has no-che?k-code (glob)" % f
             return "Skip" # skip checking this file
         for p, r in filters:
             post = re.sub(p, r, post)