# HG changeset patch # User Markus F.X.J. Oberhumer # Date 1300316095 -3600 # Node ID 15b97a1cd60b4b575d7a33ddcd8e2994c80ed2a4 # Parent 12f60626d8179c77e93dbc54c4527390a2a11ffb revset: fix a number of highly dubious continue statements This patch definitely needs a review and would also benefit from some new testsuite entries. diff -r 12f60626d817 -r 15b97a1cd60b mercurial/revset.py --- a/mercurial/revset.py Wed Mar 16 23:54:55 2011 +0100 +++ b/mercurial/revset.py Wed Mar 16 23:54:55 2011 +0100 @@ -394,7 +394,7 @@ for e in c.files() + [c.user(), c.description()]: if gr.search(e): l.append(r) - continue + break return l def author(repo, subset, x): @@ -423,7 +423,7 @@ for f in repo[r].files(): if m(f): s.append(r) - continue + break return s def contains(repo, subset, x): @@ -438,13 +438,12 @@ for r in subset: if pat in repo[r]: s.append(r) - continue else: for r in subset: for f in repo[r].manifest(): if m(f): s.append(r) - continue + break return s def checkstatus(repo, subset, pat, field): @@ -466,12 +465,11 @@ if fast: if pat in files: s.append(r) - continue else: for f in files: if m(f): s.append(r) - continue + break return s def modifies(repo, subset, x):