# HG changeset patch # User Jun Wu # Date 1504736599 25200 # Node ID 15ec3119d500b2aa065149a7ec9649787dc5d505 # Parent 8a8e7a94ba0748cd3fa1e5069ef97469a1b04887 rebase: use unfiltered repo when loading state Before this patch, `rebase --abort` may fail to do the cleanup: $ hg rebase --abort rebase aborted (no revision is removed, only broken state is cleared) The added test case makes sure `--abort` works in this case. Differential Revision: https://phab.mercurial-scm.org/D643 diff -r 8a8e7a94ba07 -r 15ec3119d500 hgext/rebase.py --- a/hgext/rebase.py Wed Sep 06 12:40:00 2017 -0700 +++ b/hgext/rebase.py Wed Sep 06 15:23:19 2017 -0700 @@ -198,7 +198,7 @@ def restorestatus(self): """Restore a previously stored status""" - repo = self.repo + repo = self.repo.unfiltered() keepbranches = None legacydest = None collapse = False diff -r 8a8e7a94ba07 -r 15ec3119d500 tests/test-rebase-obsolete.t --- a/tests/test-rebase-obsolete.t Wed Sep 06 12:40:00 2017 -0700 +++ b/tests/test-rebase-obsolete.t Wed Sep 06 15:23:19 2017 -0700 @@ -1301,3 +1301,73 @@ / o 0:426bada5c675 A +For some reasons (--hidden, rebaseskipobsolete=0, directaccess, etc.), +rebasestate may contain hidden hashes. "rebase --abort" should work regardless. + + $ hg init $TESTTMP/hidden-state1 + $ cd $TESTTMP/hidden-state1 + $ cat >> .hg/hgrc < [experimental] + > rebaseskipobsolete=0 + > EOF + + $ hg debugdrawdag <<'EOS' + > C + > | + > D B # prune: B, C + > |/ # B/D=B + > A + > EOS + + $ eval `hg tags -T '{tag}={node}\n'` + $ rm .hg/localtags + + $ hg update -q $C --hidden + $ hg rebase -s $B -d $D + rebasing 1:2ec65233581b "B" + merging D + warning: conflicts while merging D! (edit, then use 'hg resolve --mark') + unresolved conflicts (see hg resolve, then hg rebase --continue) + [1] + + $ cp -R . $TESTTMP/hidden-state2 + + $ hg log -G + @ 2:b18e25de2cf5 D + | + | @ 1:2ec65233581b B + |/ + o 0:426bada5c675 A + + $ hg summary + parent: 2:b18e25de2cf5 tip + D + parent: 1:2ec65233581b (obsolete) + B + branch: default + commit: 2 modified, 1 unknown, 1 unresolved (merge) + update: (current) + phases: 3 draft + rebase: 0 rebased, 2 remaining (rebase --continue) + + $ hg rebase --abort + rebase aborted + +Also test --continue for the above case + + $ cd $TESTTMP/hidden-state2 + $ hg resolve -m + (no more unresolved files) + continue: hg rebase --continue + $ hg rebase --continue + rebasing 1:2ec65233581b "B" + rebasing 3:7829726be4dc "C" (tip) + $ hg log -G + @ 5:1964d5d5b547 C + | + o 4:68deb90c12a2 B + | + o 2:b18e25de2cf5 D + | + o 0:426bada5c675 A +