# HG changeset patch # User Mads Kiilerich # Date 1657572476 -7200 # Node ID 1bad05cfc8181c7d264eace1da10ce8a2d7a1e2e # Parent 82efc31bd15237819e8eff3d46525d39821da1f9 rust: bump to memmap2 0.5.3, micro-timer 0.4.0, and crossbeam-channel 0.5.0 The merge in 12adf8c695ed had conflicts in rust/Cargo.lock and rust/hg-core/Cargo.toml . Let's ignore rust/Cargo.lock - it is regenerated. For rust/hg-core/Cargo.toml, stable had dd6b67d5c256 "rust: fix unsound `OwningDirstateMap`" which introduced ouroboros (and dropped stable_deref_trait). Default had ec8d9b5a5e7c "rust-hg-core: upgrade dependencies" which had a lot of churn bumping minimum versions - also patch versions. It is indeed a good idea to bump to *allow* use of latest package. That means that major versions should be bumped for packages after 1.0, and for packages below 1.0 minor versions should be bumped too. But it doesn't work to try enforce a policy of using latest patch by bumping versions at arbitrary times. For good or bad, the merge doesn't seem to have resolved the conflicts correctly, and many of the minor "upgrade dependencies" were lost again. Unfortunately, it also lost the bump of memmap2 to 0.5.3, which is needed for Fedora packaging where 0.4 isn't available. Same with micro-timer bump to 0.4 (which already is used in rhg). crossbeam-channel bump was also lost. This change fixes that regression by redoing these "important" lines of the merge "correctly". I propose this for stable, even though dependency changes on stable branches are annoying. diff -r 82efc31bd152 -r 1bad05cfc818 rust/Cargo.lock --- a/rust/Cargo.lock Thu Jul 28 14:11:53 2022 +0200 +++ b/rust/Cargo.lock Mon Jul 11 22:47:56 2022 +0200 @@ -222,22 +222,12 @@ [[package]] name = "crossbeam-channel" -version = "0.4.4" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "b153fe7cbef478c567df0f972e02e6d736db11affe43dfc9c56a9374d1adfb87" -dependencies = [ - "crossbeam-utils 0.7.2", - "maybe-uninit", -] - -[[package]] -name = "crossbeam-channel" version = "0.5.2" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "e54ea8bc3fb1ee042f5aace6e3c6e025d3874866da222930f70ce62aceba0bfa" dependencies = [ "cfg-if 1.0.0", - "crossbeam-utils 0.8.1", + "crossbeam-utils", ] [[package]] @@ -248,7 +238,7 @@ dependencies = [ "cfg-if 1.0.0", "crossbeam-epoch", - "crossbeam-utils 0.8.1", + "crossbeam-utils", ] [[package]] @@ -259,7 +249,7 @@ dependencies = [ "cfg-if 1.0.0", "const_fn", - "crossbeam-utils 0.8.1", + "crossbeam-utils", "lazy_static", "memoffset", "scopeguard", @@ -267,17 +257,6 @@ [[package]] name = "crossbeam-utils" -version = "0.7.2" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "c3c7c73a2d1e9fc0886a08b93e98eb643461230d5f1925e4036204d5f2e261a8" -dependencies = [ - "autocfg", - "cfg-if 0.1.10", - "lazy_static", -] - -[[package]] -name = "crossbeam-utils" version = "0.8.1" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "02d96d1e189ef58269ebe5b97953da3274d83a93af647c2ddd6f9dab28cedb8d" @@ -476,7 +455,7 @@ "byteorder", "bytes-cast", "clap", - "crossbeam-channel 0.4.4", + "crossbeam-channel", "derive_more", "flate2", "format-bytes", @@ -488,7 +467,7 @@ "libc", "log", "memmap2", - "micro-timer 0.3.1", + "micro-timer", "ouroboros", "pretty_assertions", "rand 0.8.5", @@ -508,7 +487,7 @@ version = "0.1.0" dependencies = [ "cpython", - "crossbeam-channel 0.5.2", + "crossbeam-channel", "env_logger", "hg-core", "libc", @@ -621,12 +600,6 @@ ] [[package]] -name = "maybe-uninit" -version = "2.0.0" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "60302e4db3a61da70c0cb7991976248362f30319e88850c487b9b95bbf059e00" - -[[package]] name = "memchr" version = "2.4.1" source = "registry+https://github.com/rust-lang/crates.io-index" @@ -634,9 +607,9 @@ [[package]] name = "memmap2" -version = "0.4.0" +version = "0.5.7" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "de5d3112c080d58ce560081baeaab7e1e864ca21795ddbf533d5b1842bb1ecf8" +checksum = "95af15f345b17af2efc8ead6080fb8bc376f8cec1b35277b935637595fe77498" dependencies = [ "libc", "stable_deref_trait", @@ -653,38 +626,16 @@ [[package]] name = "micro-timer" -version = "0.3.1" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "2620153e1d903d26b72b89f0e9c48d8c4756cba941c185461dddc234980c298c" -dependencies = [ - "micro-timer-macros 0.3.1", - "scopeguard", -] - -[[package]] -name = "micro-timer" version = "0.4.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "5de32cb59a062672560d6f0842c4aa7714727457b9fe2daf8987d995a176a405" dependencies = [ - "micro-timer-macros 0.4.0", + "micro-timer-macros", "scopeguard", ] [[package]] name = "micro-timer-macros" -version = "0.3.1" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "e28a3473e6abd6e9aab36aaeef32ad22ae0bd34e79f376643594c2b152ec1c5d" -dependencies = [ - "proc-macro2", - "quote", - "scopeguard", - "syn", -] - -[[package]] -name = "micro-timer-macros" version = "0.4.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "cee948b94700125b52dfb68dd17c19f6326696c1df57f92c05ee857463c93ba1" @@ -973,9 +924,9 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "d78120e2c850279833f1dd3582f730c4ab53ed95aeaaaa862a2a5c71b1656d8e" dependencies = [ - "crossbeam-channel 0.5.2", + "crossbeam-channel", "crossbeam-deque", - "crossbeam-utils 0.8.1", + "crossbeam-utils", "lazy_static", "num_cpus", ] @@ -1029,7 +980,7 @@ "home", "lazy_static", "log", - "micro-timer 0.4.0", + "micro-timer", "regex", "users", "which", diff -r 82efc31bd152 -r 1bad05cfc818 rust/hg-core/Cargo.toml --- a/rust/hg-core/Cargo.toml Thu Jul 28 14:11:53 2022 +0200 +++ b/rust/hg-core/Cargo.toml Mon Jul 11 22:47:56 2022 +0200 @@ -29,10 +29,10 @@ twox-hash = "1.6.2" same-file = "1.0.6" tempfile = "3.1.0" -crossbeam-channel = "0.4" -micro-timer = "0.3.0" +crossbeam-channel = "0.5.0" +micro-timer = "0.4.0" log = "0.4.8" -memmap2 = {version = "0.4", features = ["stable_deref_trait"]} +memmap2 = { version = "0.5.3", features = ["stable_deref_trait"] } zstd = "0.5.3" format-bytes = "0.3.0"