# HG changeset patch # User Matt Harbison # Date 1671218642 18000 # Node ID 1d1b244a91b603a266aad491b6a8a6b5d978411a # Parent 54114bba7c7eac695f0b4de54f0704d1cfef0912 util: fix the signature of observedbufferedinputpipe._fillbuffer() Flagged by PyCharm, since it didn't match the signature of the method being overridden. The default value in the superclass is also `_chunksize`, and I suspect that the amount read from `osread` should be limited to what is passed in. Only one caller (`bufferedinputpipe.unbufferedread()`) passes this argument, and it passes the max of `_chunksize` and whatever it was passed. diff -r 54114bba7c7e -r 1d1b244a91b6 mercurial/util.py --- a/mercurial/util.py Fri Dec 16 14:15:09 2022 -0500 +++ b/mercurial/util.py Fri Dec 16 14:24:02 2022 -0500 @@ -642,12 +642,12 @@ ``read()`` and ``readline()``. """ - def _fillbuffer(self): - res = super(observedbufferedinputpipe, self)._fillbuffer() + def _fillbuffer(self, size=_chunksize): + res = super(observedbufferedinputpipe, self)._fillbuffer(size=size) fn = getattr(self._input._observer, 'osread', None) if fn: - fn(res, _chunksize) + fn(res, size) return res