# HG changeset patch # User Pierre-Yves David # Date 1675355011 -3600 # Node ID 2452843baf9008ca159d2221077401c6fd0122f9 # Parent 309a7ecef246b6dde626e6b970e739e6f3dda29a safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage. diff -r 309a7ecef246 -r 2452843baf90 mercurial/dispatch.py --- a/mercurial/dispatch.py Thu Feb 02 17:23:20 2023 +0100 +++ b/mercurial/dispatch.py Thu Feb 02 17:23:31 2023 +0100 @@ -116,7 +116,7 @@ err = e status = -1 - if util.safehasattr(ui, b'ferr'): + if util.safehasattr(ui, 'ferr'): assert ui is not None # help pytype assert ui.ferr is not None # help pytype try: