# HG changeset patch # User Pierre-Yves David # Date 1397248981 14400 # Node ID 27ab4b8d250352987f68c7060c8dde5df81ec635 # Parent 0f7e01e0c06f19b9b26c1b571a4b6de6b15d7cbd bundle2: comment to clarify why the handler call is where it is The reason why it is here is not obvious. I'm the one who wrote it there in the first place and almost moved it 2 weeks later. diff -r 0f7e01e0c06f -r 27ab4b8d2503 mercurial/bundle2.py --- a/mercurial/bundle2.py Sat Apr 12 00:53:15 2014 -0400 +++ b/mercurial/bundle2.py Fri Apr 11 16:43:01 2014 -0400 @@ -305,6 +305,11 @@ # todo: # - consume the part once we use streaming continue + + # handler is called outside the above try block so that we don't + # risk catching KeyErrors from anything other than the + # parthandlermapping lookup (any KeyError raised by handler() + # itself represents a defect of a different variety). handler(op, part) except Exception: for part in iterparts: