# HG changeset patch # User Pierre-Yves David # Date 1443081006 25200 # Node ID 2aa0dde846b4e86b1fc5693c0c01d13a33257613 # Parent cd9cc7f3042739b88cd6e28d940be10648441560 mq: remove a mutable default argument Mutable default arguments are know to the state of California to cause bugs. The underlying function already handle "None" as an option value, so we do not need to do anything else. diff -r cd9cc7f30427 -r 2aa0dde846b4 hgext/mq.py --- a/hgext/mq.py Thu Sep 24 00:49:02 2015 -0700 +++ b/hgext/mq.py Thu Sep 24 00:50:06 2015 -0700 @@ -483,7 +483,7 @@ self.guardsdirty = False self.activeguards = None - def diffopts(self, opts={}, patchfn=None): + def diffopts(self, opts=None, patchfn=None): diffopts = patchmod.diffopts(self.ui, opts) if self.gitmode == 'auto': diffopts.upgrade = True