# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1536980858 -32400
# Node ID 2b91805e34c7c4c650a82144eee53b80b0238840
# Parent  78ee63c77bb34d54bf9175592a35fb7bb82a86de
bookmarks: clarify that opts['rename'] points to an old bookmark to be renamed

diff -r 78ee63c77bb3 -r 2b91805e34c7 mercurial/commands.py
--- a/mercurial/commands.py	Sat Sep 15 12:04:29 2018 +0900
+++ b/mercurial/commands.py	Sat Sep 15 12:07:38 2018 +0900
@@ -961,7 +961,6 @@
     opts = pycompat.byteskwargs(opts)
     force = opts.get('force')
     rev = opts.get('rev')
-    rename = opts.get('rename')
     inactive = opts.get('inactive')
 
     selactions = [k for k in ['delete', 'rename', 'active'] if opts.get(k)]
@@ -992,8 +991,8 @@
                     raise error.Abort(_("new bookmark name required"))
                 elif len(names) > 1:
                     raise error.Abort(_("only one new bookmark name allowed"))
-                rename = repo._bookmarks.expandname(rename)
-                bookmarks.rename(repo, tr, rename, names[0], force, inactive)
+                oldname = repo._bookmarks.expandname(opts['rename'])
+                bookmarks.rename(repo, tr, oldname, names[0], force, inactive)
             elif names:
                 bookmarks.addbookmarks(repo, tr, names, rev, force, inactive)
             elif inactive: