# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1443081378 25200
# Node ID 2cd19782d2d49d0ac2ef23b7968ed16d94a182d4
# Parent  db4c192cb9b3744c42b85af45ea6c8015d271bcc
commit: remove a mutable default argument

Mutable default arguments are know to the state of California to cause bugs.

diff -r db4c192cb9b3 -r 2cd19782d2d4 mercurial/localrepo.py
--- a/mercurial/localrepo.py	Tue Sep 22 14:09:42 2015 -0700
+++ b/mercurial/localrepo.py	Thu Sep 24 00:56:18 2015 -0700
@@ -1378,13 +1378,15 @@
 
     @unfilteredmethod
     def commit(self, text="", user=None, date=None, match=None, force=False,
-               editor=False, extra={}):
+               editor=False, extra=None):
         """Add a new revision to current repository.
 
         Revision information is gathered from the working directory,
         match can be used to filter the committed files. If editor is
         supplied, it is called to get a commit message.
         """
+        if extra is None:
+            extra = {}
 
         def fail(f, msg):
             raise util.Abort('%s: %s' % (f, msg))