# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1485817397 18000
# Node ID 2d6b86cadc1039f7cf72b64c29399bebe02e7dd3
# Parent  6cd99ec908fa43cbce7400f72a09ee6d844f2d06
tests: correct (I think) command in test-largefiles-update

When this test was introduced, it used the short-form of all the flags
on this update invocation. I suspect, based on the "start with clean
dirstates" comment and the fact that the no-exec branch of the #if
guard leaves dirstate clean, that this should have been 'update -qCr'
instead of 'update -qcr', but that a bug in largefiles --check
handling left this problem unnoticed.

I'll leave a breadcrumb further up about the current failure mode in
the hopes that we can fix this some day.

This was previously discussed in [0] but the trail in that thread goes
cold after a few replies. Given that this is still a flaky test, that
appears to only be passing by bad fortune, I think it's worth
correcting the code of the test to make a correct assertion, and to
keep track of the suspected bug with some other mechanism than an
invalid test (if we had support for "expected failure" blocks this
might be a worthwhile use of them?).

0: https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-October/089501.html

diff -r 6cd99ec908fa -r 2d6b86cadc10 tests/test-largefiles-update.t
--- a/tests/test-largefiles-update.t	Mon Jan 30 17:57:21 2017 -0500
+++ b/tests/test-largefiles-update.t	Mon Jan 30 18:03:17 2017 -0500
@@ -737,7 +737,7 @@
 hashes reveals it isn't clean.
 
 Start with clean dirstates:
-  $ hg up --quiet --check --rev "8^"
+  $ hg up --quiet --clean --rev "8^"
   $ sleep 1
   $ hg st
 Update standins without updating largefiles - large1 is modified and largeX is