# HG changeset patch # User Simon Heimberg # Date 1392590162 -3600 # Node ID 2e68882852eef1d14a03008c981d8dfce6d4166d # Parent dad29624b05663f7e785e333ad48d5a530dd5b37 run-tests: fixed warn detection on detecting warn only for lines The state "warned" was reported too often. The main problem was that "False == 0" is true in python. Therefore use an empty string instead of 0 for reporting warn only for a line. The other problem is fixed in the next patch. diff -r dad29624b056 -r 2e68882852ee tests/run-tests.py --- a/tests/run-tests.py Thu Feb 27 20:01:28 2014 -0800 +++ b/tests/run-tests.py Sun Feb 16 23:36:02 2014 +0100 @@ -797,10 +797,10 @@ if isinstance(r, str): if r == '+glob': lout = el[:-1] + ' (glob)\n' - r = 0 # warn only + r = '' # warn only this line elif r == '-glob': lout = ''.join(el.rsplit(' (glob)', 1)) - r = 0 # warn only + r = '' # warn only this line else: log('\ninfo, unknown linematch result: %r\n' % r) r = False @@ -810,7 +810,7 @@ if needescape(lout): lout = stringescape(lout.rstrip('\n')) + " (esc)\n" postout.append(" " + lout) # let diff deal with it - if r != 0: # != warn only + if r != '': # if line failed warnonly = False if lcmd: