# HG changeset patch
# User Martin Geisler <mg@lazybytes.net>
# Date 1289430489 -3600
# Node ID 34034e55424fec7a171806786ca836856d28fc99
# Parent  e80128e40c044ea6619c3dc160df69ad36a8e5ff
check-code: using and/or/not as a function is bad style

diff -r e80128e40c04 -r 34034e55424f contrib/check-code.py
--- a/contrib/check-code.py	Wed Nov 10 15:44:19 2010 +0100
+++ b/contrib/check-code.py	Thu Nov 11 00:08:09 2010 +0100
@@ -118,6 +118,9 @@
      "linebreak after :"),
     (r'class\s[^(]:', "old-style class, use class foo(object)"),
     (r'^\s+del\(', "del isn't a function"),
+    (r'\band\(', "and isn't a function"),
+    (r'\bor\(', "or isn't a function"),
+    (r'\bnot\(', "not isn't a function"),
     (r'^\s+except\(', "except isn't a function"),
     (r',]', "unneeded trailing ',' in list"),
 #    (r'class\s[A-Z][^\(]*\((?!Exception)',
diff -r e80128e40c04 -r 34034e55424f mercurial/commands.py
--- a/mercurial/commands.py	Wed Nov 10 15:44:19 2010 +0100
+++ b/mercurial/commands.py	Thu Nov 11 00:08:09 2010 +0100
@@ -1120,7 +1120,7 @@
         key, old, new = keyinfo
         r = target.pushkey(namespace, key, old, new)
         ui.status(str(r) + '\n')
-        return not(r)
+        return not r
     else:
         for k, v in target.listkeys(namespace).iteritems():
             ui.write("%s\t%s\n" % (k.encode('string-escape'),
diff -r e80128e40c04 -r 34034e55424f mercurial/demandimport.py
--- a/mercurial/demandimport.py	Wed Nov 10 15:44:19 2010 +0100
+++ b/mercurial/demandimport.py	Thu Nov 11 00:08:09 2010 +0100
@@ -111,7 +111,7 @@
             mod = getattr(mod, comp)
         for x in fromlist:
             # set requested submodules for demand load
-            if not(hasattr(mod, x)):
+            if not hasattr(mod, x):
                 setattr(mod, x, _demandmod(x, mod.__dict__, locals))
         return mod