# HG changeset patch # User Denis Laxalde # Date 1570734013 -7200 # Node ID 3941e7063d035ec54d53edd076367f6b23a04c7d # Parent 01e8eefd943406c645df4dff11871683d35848b5 py3: call SMTP.has_extn() with an str Passing a bytes on Python 3 always returns False, thus starttls is not properly detected. diff -r 01e8eefd9434 -r 3941e7063d03 mercurial/mail.py --- a/mercurial/mail.py Thu Oct 10 20:27:34 2019 +0200 +++ b/mercurial/mail.py Thu Oct 10 21:00:13 2019 +0200 @@ -49,7 +49,7 @@ self._host = host def starttls(self, keyfile=None, certfile=None): - if not self.has_extn(b"starttls"): + if not self.has_extn("starttls"): msg = b"STARTTLS extension not supported by server" raise smtplib.SMTPException(msg) (resp, reply) = self.docmd(b"STARTTLS")