# HG changeset patch # User Augie Fackler # Date 1507718891 25200 # Node ID 3e4b7861c1c56dd19252230d50206f2a148424d1 # Parent d6d10771950c277fec9b2e2e07ef694161c3f1a5 contrib: add check-code rule banning use of readlink readlink doesn't always exist, such as on Solaris-derived platforms. Differential Revision: https://phab.mercurial-scm.org/D1000 diff -r d6d10771950c -r 3e4b7861c1c5 contrib/check-code.py --- a/contrib/check-code.py Tue Oct 10 11:03:14 2017 -0400 +++ b/contrib/check-code.py Wed Oct 11 03:48:11 2017 -0700 @@ -203,6 +203,7 @@ 'use test -f to test for file existence'), (r'^ diff -[^ -]*p', "don't use (external) diff with -p for portability"), + (r' readlink ', 'use readlink.py instead of readlink'), (r'^ [-+][-+][-+] .* [-+]0000 \(glob\)', "glob timezone field in diff output for portability"), (r'^ @@ -[0-9]+ [+][0-9]+,[0-9]+ @@',