# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1442994067 25200
# Node ID 428a8747f4eeabe36efc411d216bbe0e39faae12
# Parent  d157e1f18e3f529006217e1584edeec1d9288485
revset: avoid implicit None testing in revset

Implicit None testing is a very good way to get in trouble. We explicitly test
for None.

diff -r d157e1f18e3f -r 428a8747f4ee mercurial/revset.py
--- a/mercurial/revset.py	Sun Sep 20 16:53:42 2015 -0700
+++ b/mercurial/revset.py	Wed Sep 23 00:41:07 2015 -0700
@@ -3225,10 +3225,13 @@
         return lambda: self._iterfilter(it())
 
     def __nonzero__(self):
-        it = self
-        fast = self.fastasc or self.fastdesc
-        if fast:
+        fast = self.fastasc
+        if fast is None:
+            fast = self.fastdesc
+        if fast is not None:
             it = fast()
+        else:
+            it = self
 
         for r in it:
             return True