# HG changeset patch # User Durham Goode # Date 1369964836 25200 # Node ID 446ab88d3f1c55f7c33e965a2cd598787d2476a4 # Parent e0aa6fff8f0241a0b655a15a3856b9ddf8bb0cb3 filelog: switch 'not len(filerevlog)' to 'not filerevlog' A few places in the code use 'if not len(revlog)' to check if the revlog exists. Replacing this with 'not filerevlog' allows alternative revlog implementations to override __nonzero__ to handle this case without implementing __len__. diff -r e0aa6fff8f02 -r 446ab88d3f1c mercurial/changegroup.py --- a/mercurial/changegroup.py Thu May 30 19:29:03 2013 -0700 +++ b/mercurial/changegroup.py Thu May 30 18:47:16 2013 -0700 @@ -359,7 +359,7 @@ msgfiles = _('files') for i, fname in enumerate(sorted(changedfiles)): filerevlog = repo.file(fname) - if not len(filerevlog): + if not filerevlog: raise util.Abort(_("empty or missing revlog for %s") % fname) if fastpathlinkrev: diff -r e0aa6fff8f02 -r 446ab88d3f1c mercurial/cmdutil.py --- a/mercurial/cmdutil.py Thu May 30 19:29:03 2013 -0700 +++ b/mercurial/cmdutil.py Thu May 30 18:47:16 2013 -0700 @@ -1338,7 +1338,7 @@ raise util.Abort(_('cannot follow file not in parent ' 'revision: "%s"') % f) filelog = repo.file(f) - if not len(filelog): + if not filelog: # A zero count may be a directory or deleted file, so # try to find matching entries on the slow path. if follow: