# HG changeset patch # User Martin von Zweigbergk # Date 1522817442 25200 # Node ID 44f3b60deafbd2a52df7f7a0064d2bdc265d7632 # Parent b48b7b130d08d40197e5245afcbd4151a0f971c0 hgweb: drop support for "manifest" parameter AFAICT (but note that this is the first time I look at hgweb code), the "mercurial" query parameter was removed from rendered pages in 36fa5db79dd5 (hgweb: convert gitweb to NWI, 2006-10-05). Search for "manifest=" in that diff to see why I think it was removed. It's about time we stop looking for the parameter in requests. Differential Revision: https://phab.mercurial-scm.org/D3073 diff -r b48b7b130d08 -r 44f3b60deafb mercurial/hgweb/webutil.py --- a/mercurial/hgweb/webutil.py Wed Apr 04 10:32:48 2018 -0700 +++ b/mercurial/hgweb/webutil.py Tue Apr 03 21:50:42 2018 -0700 @@ -296,13 +296,7 @@ return pathutil.canonpath(repo.root, '', path) def changeidctx(repo, changeid): - try: - ctx = repo[changeid] - except error.RepoError: - man = repo.manifestlog._revlog - ctx = repo[man.linkrev(man.rev(man.lookup(changeid)))] - - return ctx + return repo[changeid] def changectx(repo, req): changeid = "tip" @@ -311,8 +305,6 @@ ipos = changeid.find(':') if ipos != -1: changeid = changeid[(ipos + 1):] - elif 'manifest' in req.qsparams: - changeid = req.qsparams['manifest'] return changeidctx(repo, changeid)