# HG changeset patch # User Martin von Zweigbergk # Date 1529014112 25200 # Node ID 48c52385e0627241ca0f9720ec7ee69ac607929b # Parent e218ed5ba484fec05e605da9cd821f35271d63d8 tag: use context manager for locks Differential Revision: https://phab.mercurial-scm.org/D3746 diff -r e218ed5ba484 -r 48c52385e062 mercurial/commands.py --- a/mercurial/commands.py Thu Jun 14 15:05:14 2018 -0700 +++ b/mercurial/commands.py Thu Jun 14 15:08:32 2018 -0700 @@ -5356,10 +5356,7 @@ Returns 0 on success. """ opts = pycompat.byteskwargs(opts) - wlock = lock = None - try: - wlock = repo.wlock() - lock = repo.lock() + with repo.wlock(), repo.lock(): rev_ = "." names = [t.strip() for t in (name1,) + names] if len(names) != len(set(names)): @@ -5430,8 +5427,6 @@ tagsmod.tag(repo, names, node, message, opts.get('local'), opts.get('user'), date, editor=editor) - finally: - release(lock, wlock) @command('tags', formatteropts, '', intents={INTENT_READONLY}) def tags(ui, repo, **opts):