# HG changeset patch # User Yuya Nishihara # Date 1420893402 -32400 # Node ID 4982fade9733014b070d3b6556ca1dc8fbba9c19 # Parent b2358bc1407c19007b0e7852262f61d5fe7a8f83 revset: simplify fullreposet.__and__ to call sort() with boolean flag Note that sort() takes a boolean flag, so other.sort(reverse) was wrong. It just worked fine because there is a top-level function, reverse(). diff -r b2358bc1407c -r 4982fade9733 mercurial/revset.py --- a/mercurial/revset.py Tue Jan 13 15:08:55 2015 -0500 +++ b/mercurial/revset.py Sat Jan 10 21:36:42 2015 +0900 @@ -3102,10 +3102,7 @@ # object. other = baseset(other - self._hiddenrevs) - if self.isascending(): - other.sort() - else: - other.sort(reverse) + other.sort(reverse=self.isdescending()) return other # tell hggettext to extract docstrings from these functions: