# HG changeset patch
# User Matt Mackall <mpm@selenic.com>
# Date 1402687034 18000
# Node ID 4ab287c2d3378289f0a8125cfba955d1183e472d
# Parent  f13728d59c0e146060649986041af35ec7b3f8c9
revlog: hold a private reference to self._cache

This keeps other threads from modifying self._cache out from under us.
With this and the previous fix, 'hg serve' survives 100k hits with siege.

diff -r f13728d59c0e -r 4ab287c2d337 mercurial/revlog.py
--- a/mercurial/revlog.py	Fri Jun 13 14:16:03 2014 -0500
+++ b/mercurial/revlog.py	Fri Jun 13 14:17:14 2014 -0500
@@ -972,13 +972,14 @@
             node = nodeorrev
             rev = None
 
+        _cache = self._cache # grab local copy of cache to avoid thread race
         cachedrev = None
         if node == nullid:
             return ""
-        if self._cache:
-            if self._cache[0] == node:
-                return self._cache[2]
-            cachedrev = self._cache[1]
+        if _cache:
+            if _cache[0] == node:
+                return _cache[2]
+            cachedrev = _cache[1]
 
         # look up what we need to read
         text = None
@@ -1006,7 +1007,7 @@
 
         if iterrev == cachedrev:
             # cache hit
-            text = self._cache[2]
+            text = _cache[2]
         else:
             chain.append(iterrev)
         chain.reverse()