# HG changeset patch # User Jordi GutiƩrrez Hermoso # Date 1426009214 14400 # Node ID 5058e6962fcca9194ca78a5436902513168437e9 # Parent 913347bcd59c33110f029d83203b3b4c2ecd91a8 color: omit terminfo/win32 warning if non-interactive (issue4543) It's pretty annoying to be getting this warning when already the colour extension has no hope of working. If there isn't a human on the other end to to see the colours, there probably isn't a human either who cares about this warning. More likely, some script somewhere is gonna get confused with the warning output. Of course, if we still want to see the warning for some reason, we can always set --config ui.interactive=True. diff -r 913347bcd59c -r 5058e6962fcc hgext/color.py --- a/hgext/color.py Thu Feb 26 20:54:05 2015 +0900 +++ b/hgext/color.py Tue Mar 10 13:40:14 2015 -0400 @@ -254,7 +254,7 @@ if realmode == 'win32': _terminfo_params = {} if not w32effects: - if mode == 'win32': + if mode == 'win32' and ui.interactive(): # only warn if color.mode is explicitly set to win32 ui.warn(_('warning: failed to set color mode to %s\n') % mode) return None @@ -264,7 +264,7 @@ elif realmode == 'terminfo': _terminfosetup(ui, mode) if not _terminfo_params: - if mode == 'terminfo': + if mode == 'terminfo' and ui.interactive(): ## FIXME Shouldn't we return None in this case too? # only warn if color.mode is explicitly set to win32 ui.warn(_('warning: failed to set color mode to %s\n') % mode)