# HG changeset patch # User Pierre-Yves David # Date 1309854027 -7200 # Node ID 5097d8b5078ca1cab7d0d9f8fb8d5b9896e401b7 # Parent 677339529a53a98e0bfb7b2ddfd715d3ef0f62f5 bookmarks: add a warning for non empty malformed line diff -r 677339529a53 -r 5097d8b5078c mercurial/bookmarks.py --- a/mercurial/bookmarks.py Tue Jul 05 10:13:54 2011 +0200 +++ b/mercurial/bookmarks.py Tue Jul 05 10:20:27 2011 +0200 @@ -28,6 +28,9 @@ for line in repo.opener('bookmarks'): line = line.strip() if ' ' not in line: + if line: + msg = _('malformed line in .hg/bookmarks: %r\n') + repo.ui.warn( msg % line) continue sha, refspec = line.strip().split(' ', 1) refspec = encoding.tolocal(refspec) diff -r 677339529a53 -r 5097d8b5078c tests/test-bookmarks.t --- a/tests/test-bookmarks.t Tue Jul 05 10:13:54 2011 +0200 +++ b/tests/test-bookmarks.t Tue Jul 05 10:20:27 2011 +0200 @@ -350,3 +350,11 @@ Y 2:db815d6d32e6 * Z 3:125c9a1d6df6 x y 2:db815d6d32e6 + $ echo "Ican'thasformatedlines" >> .hg/bookmarks + $ hg bookmarks + malformed line in .hg/bookmarks: "Ican'thasformatedlines" + X2 1:925d80f479bb + Y 2:db815d6d32e6 + * Z 3:125c9a1d6df6 + x y 2:db815d6d32e6 +