# HG changeset patch # User Steve Borho # Date 1293045900 21600 # Node ID 5314cbb775f6e2034be96bc64a54a0ec7c553a19 # Parent f5be619663f9e229e1dd8bd4597cff6940d92709 convert: subversion should use util.quotecommand to wrap args to popen2 All other callers of util.popen2 and util.popen3 do this, as well as direct callers of subprocess.Popen. diff -r f5be619663f9 -r 5314cbb775f6 hgext/convert/subversion.py --- a/hgext/convert/subversion.py Thu Dec 23 13:23:20 2010 -0600 +++ b/hgext/convert/subversion.py Wed Dec 22 13:25:00 2010 -0600 @@ -914,7 +914,7 @@ arg = encodeargs(args) hgexe = util.hgexecutable() cmd = '%s debugsvnlog' % util.shellquote(hgexe) - stdin, stdout = util.popen2(cmd) + stdin, stdout = util.popen2(util.quotecommand(cmd)) stdin.write(arg) try: stdin.close()