# HG changeset patch # User Pierre-Yves David # Date 1443081605 25200 # Node ID 58218b0e6005c8169350b88ce9cff648fe3eeadc # Parent cce8ebd3140773c0a95fedb4b3835be55385dbc3 match: remove a mutable default argument Mutable default arguments are know to the state of California to cause bugs. diff -r cce8ebd31407 -r 58218b0e6005 mercurial/scmutil.py --- a/mercurial/scmutil.py Thu Sep 24 00:59:26 2015 -0700 +++ b/mercurial/scmutil.py Thu Sep 24 01:00:05 2015 -0700 @@ -753,13 +753,15 @@ ret.append(kindpat) return ret -def matchandpats(ctx, pats=(), opts={}, globbed=False, default='relpath', +def matchandpats(ctx, pats=(), opts=None, globbed=False, default='relpath', badfn=None): '''Return a matcher and the patterns that were used. The matcher will warn about bad matches, unless an alternate badfn callback is provided.''' if pats == ("",): pats = [] + if opts is None: + opts = {} if not globbed and default == 'relpath': pats = expandpats(pats or [])