# HG changeset patch
# User Marc-Antoine Ruel <maruel@google.com>
# Date 1321487732 21600
# Node ID 58f96703a9abd4c64c3c164ecef6ba8df3534446
# Parent  ac5a340b26defa58eca5ae437f1a02d5508a5ceb
posix: fix findexe() to check for file type and access

diff -r ac5a340b26de -r 58f96703a9ab mercurial/posix.py
--- a/mercurial/posix.py	Tue Nov 15 02:16:30 2011 +0100
+++ b/mercurial/posix.py	Wed Nov 16 17:55:32 2011 -0600
@@ -258,7 +258,7 @@
 
     def findexisting(executable):
         'Will return executable if existing file'
-        if os.path.exists(executable):
+        if os.path.isfile(executable) and os.access(executable, os.X_OK):
             return executable
         return None
 
@@ -268,9 +268,7 @@
     for path in os.environ.get('PATH', '').split(os.pathsep):
         executable = findexisting(os.path.join(path, command))
         if executable is not None:
-            st = os.stat(executable)
-            if (st.st_mode & (stat.S_IXUSR | stat.S_IXGRP | stat.S_IXOTH)):
-                return executable
+            return executable
     return None
 
 def setsignalhandler():