# HG changeset patch # User Martin von Zweigbergk # Date 1593117476 25200 # Node ID 6118ad07b98dfe3d764b8212f689760bd8c16a25 # Parent c63a297fb964b8b5d4c48dc4a75b04f25d72884b graft: leverage cmdutil.check_incompatible_arguments() for --abort/--stop Differential Revision: https://phab.mercurial-scm.org/D8669 diff -r c63a297fb964 -r 6118ad07b98d mercurial/commands.py --- a/mercurial/commands.py Thu Jun 25 13:29:05 2020 -0700 +++ b/mercurial/commands.py Thu Jun 25 13:37:56 2020 -0700 @@ -2995,35 +2995,34 @@ graftstate = statemod.cmdstate(repo, b'graftstate') if opts.get(b'stop'): - if any( - ( - opts.get(b'edit'), - opts.get(b'log'), - opts.get(b'user'), - opts.get(b'date'), - opts.get(b'currentdate'), - opts.get(b'currentuser'), - opts.get(b'rev'), - ) - ): - raise error.Abort(_(b"cannot specify any other flag with '--stop'")) + cmdutil.check_incompatible_arguments( + opts, + b'stop', + [ + b'edit', + b'log', + b'user', + b'date', + b'currentdate', + b'currentuser', + b'rev', + ], + ) return _stopgraft(ui, repo, graftstate) elif opts.get(b'abort'): - if any( - ( - opts.get(b'edit'), - opts.get(b'log'), - opts.get(b'user'), - opts.get(b'date'), - opts.get(b'currentdate'), - opts.get(b'currentuser'), - opts.get(b'rev'), - ) - ): - raise error.Abort( - _(b"cannot specify any other flag with '--abort'") - ) - + cmdutil.check_incompatible_arguments( + opts, + b'abort', + [ + b'edit', + b'log', + b'user', + b'date', + b'currentdate', + b'currentuser', + b'rev', + ], + ) return cmdutil.abortgraft(ui, repo, graftstate) elif opts.get(b'continue'): cont = True diff -r c63a297fb964 -r 6118ad07b98d tests/test-graft-interrupted.t --- a/tests/test-graft-interrupted.t Thu Jun 25 13:29:05 2020 -0700 +++ b/tests/test-graft-interrupted.t Thu Jun 25 13:37:56 2020 -0700 @@ -253,13 +253,13 @@ [255] $ hg graft --stop -U - abort: cannot specify any other flag with '--stop' + abort: cannot specify both --stop and --user [255] $ hg graft --stop --rev 4 - abort: cannot specify any other flag with '--stop' + abort: cannot specify both --stop and --rev [255] $ hg graft --stop --log - abort: cannot specify any other flag with '--stop' + abort: cannot specify both --stop and --log [255] $ hg graft --stop @@ -363,11 +363,11 @@ [255] $ hg graft --abort --currentuser - abort: cannot specify any other flag with '--abort' + abort: cannot specify both --abort and --user [255] $ hg graft --abort --edit - abort: cannot specify any other flag with '--abort' + abort: cannot specify both --abort and --edit [255] #if abortcommand