# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
# Date 1482370203 -3600
# Node ID 683606a829e889eb25956cd064314af9b5f68838
# Parent  ddc80d1777a63db18c7dbc35831601541f30daf6
color: rework conditional 'valideffect'

Not very important, but the full conditional is not that hard to follow and
having it unified make the function role a bit clearer in my opinion.

diff -r ddc80d1777a6 -r 683606a829e8 mercurial/color.py
--- a/mercurial/color.py	Thu Dec 22 02:26:50 2016 +0100
+++ b/mercurial/color.py	Thu Dec 22 02:30:03 2016 +0100
@@ -116,10 +116,6 @@
 
 def valideffect(effect):
     'Determine if the effect is valid or not.'
-    good = False
-    if not _terminfo_params and effect in _effects:
-        good = True
-    elif (effect in _terminfo_params
-          or effect[:-11] in _terminfo_params):
-        good = True
-    return good
+    return ((not _terminfo_params and effect in _effects)
+             or (effect in _terminfo_params
+                 or effect[:-11] in _terminfo_params))