# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1434409577 25200
# Node ID 6c48f012d37e67c3a0a33960a442340e494af9cc
# Parent  a13c18c14ade55515fdee74b9eedc39d047c4d6a
phase: remove a 'for x in "foo bar".split()' idiom in phasecache.replace

I find this idiom fairly horrible.

diff -r a13c18c14ade -r 6c48f012d37e mercurial/phases.py
--- a/mercurial/phases.py	Mon Jun 15 16:06:24 2015 -0700
+++ b/mercurial/phases.py	Mon Jun 15 16:06:17 2015 -0700
@@ -172,7 +172,7 @@
 
     def replace(self, phcache):
         """replace all values in 'self' with content of phcache"""
-        for a in 'phaseroots dirty opener _phaserevs _phasesets'.split():
+        for a in ('phaseroots', 'dirty', 'opener', '_phaserevs', '_phasesets'):
             setattr(self, a, getattr(phcache, a))
 
     def _getphaserevsnative(self, repo):