# HG changeset patch # User Augie Fackler # Date 1588884963 14400 # Node ID 6d3768b1124104bac5eead026d7e2d4c34ae7807 # Parent 3b7aabd02e11fcfc015b3a90a0c52d971a7b8a83 diff: avoid going from contexts to nodes and back This will allow us to pass in-memory contexts that may not have a valid node to the diffing logic. Differential Revision: https://phab.mercurial-scm.org/D8503 diff -r 3b7aabd02e11 -r 6d3768b11241 mercurial/commands.py --- a/mercurial/commands.py Thu May 07 16:54:17 2020 -0400 +++ b/mercurial/commands.py Thu May 07 16:56:03 2020 -0400 @@ -2489,10 +2489,13 @@ else: repo = scmutil.unhidehashlikerevs(repo, revs, b'nowarn') ctx1, ctx2 = scmutil.revpair(repo, revs) - node1, node2 = ctx1.node(), ctx2.node() if reverse: - node1, node2 = node2, node1 + ctxleft = ctx2 + ctxright = ctx1 + else: + ctxleft = ctx1 + ctxright = ctx2 diffopts = patch.diffallopts(ui, opts) m = scmutil.match(ctx2, pats, opts) @@ -2502,8 +2505,8 @@ ui, repo, diffopts, - repo[node1], - repo[node2], + ctxleft, + ctxright, m, stat=stat, listsubrepos=opts.get(b'subrepos'),