# HG changeset patch # User Pierre-Yves David # Date 1489615554 25200 # Node ID 6e1c79578e5cb619b838f0f4683dbed1cb65d4a9 # Parent 406705701c2d77a527794d40068278d07bec877a mq: explicitly tests for None Changeset fd3d8eb7f545 removed the mutable default value, but did not explicitly tested for None. Such implicit testing can introduce semantic and performance issue. We move to an explicit testing for None as recommended by PEP8: https://www.python.org/dev/peps/pep-0008/#programming-recommendations diff -r 406705701c2d -r 6e1c79578e5c hgext/mq.py --- a/hgext/mq.py Wed Mar 15 15:03:43 2017 -0700 +++ b/hgext/mq.py Wed Mar 15 15:05:54 2017 -0700 @@ -722,7 +722,8 @@ def printdiff(self, repo, diffopts, node1, node2=None, files=None, fp=None, changes=None, opts=None): - opts = opts or {} + if opts is None: + opts = {} stat = opts.get('stat') m = scmutil.match(repo[node1], files, opts) cmdutil.diffordiffstat(self.ui, repo, diffopts, node1, node2, m,