# HG changeset patch # User Mads Kiilerich # Date 1408070265 -7200 # Node ID 77142de48ae431f022204213125a0335055b1177 # Parent f72d73937853b9f752905fe3a5251a2eb70965b4 cleanup: make sure we always access members of imported modules This will make sure we get import errors, even if demandimport is enabled. This will also mute some pyflakes 'imported but unused' warnings. diff -r f72d73937853 -r 77142de48ae4 contrib/win32/hgwebdir_wsgi.py --- a/contrib/win32/hgwebdir_wsgi.py Fri Aug 15 20:28:51 2014 +0900 +++ b/contrib/win32/hgwebdir_wsgi.py Fri Aug 15 04:37:45 2014 +0200 @@ -52,6 +52,7 @@ # Enable tracing. Run 'python -m win32traceutil' to debug if getattr(sys, 'isapidllhandle', None) is not None: import win32traceutil + win32traceutil.SetupForPrint # silence unused import warning # To serve pages in local charset instead of UTF-8, remove the two lines below import os @@ -90,6 +91,6 @@ return isapi_wsgi.ISAPISimpleHandler(handler) if __name__=='__main__': - from isapi.install import * + from isapi.install import ISAPIParameters, HandleCommandLine params = ISAPIParameters() HandleCommandLine(params) diff -r f72d73937853 -r 77142de48ae4 setup.py --- a/setup.py Fri Aug 15 20:28:51 2014 +0900 +++ b/setup.py Fri Aug 15 04:37:45 2014 +0200 @@ -33,12 +33,14 @@ except ImportError: try: import sha + sha.sha # silence unused import warning except ImportError: raise SystemExit( "Couldn't import standard hashlib (incomplete Python install).") try: import zlib + zlib.compressobj # silence unused import warning except ImportError: raise SystemExit( "Couldn't import standard zlib (incomplete Python install).") @@ -56,6 +58,7 @@ else: try: import bz2 + bz2.BZ2Compressor # silence unused import warning except ImportError: raise SystemExit( "Couldn't import standard bz2 (incomplete Python install).") @@ -129,6 +132,7 @@ # py2exe needs to be installed to work try: import py2exe + py2exe.Distribution # silence unused import warning py2exeloaded = True # import py2exe's patched Distribution class from distutils.core import Distribution diff -r f72d73937853 -r 77142de48ae4 tests/hghave.py --- a/tests/hghave.py Fri Aug 15 20:28:51 2014 +0900 +++ b/tests/hghave.py Fri Aug 15 04:37:45 2014 +0200 @@ -148,6 +148,7 @@ def has_lsprof(): try: import _lsprof + _lsprof.Profiler # silence unused import warning return True except ImportError: return False @@ -164,6 +165,7 @@ def has_docutils(): try: from docutils.core import publish_cmdline + publish_cmdline # silence unused import return True except ImportError: return False @@ -270,6 +272,7 @@ def has_pygments(): try: import pygments + pygments.highlight # silence unused import warning return True except ImportError: return False @@ -288,6 +291,7 @@ def has_ssl(): try: import ssl + ssl.wrap_socket # silence unused import warning import OpenSSL OpenSSL.SSL.Context return True diff -r f72d73937853 -r 77142de48ae4 tests/test-check-pyflakes.t --- a/tests/test-check-pyflakes.t Fri Aug 15 20:28:51 2014 +0900 +++ b/tests/test-check-pyflakes.t Fri Aug 15 04:37:45 2014 +0200 @@ -7,16 +7,6 @@ $ hg locate 'set:**.py or grep("^!#.*python")' 2>/dev/null \ > | xargs pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py" - contrib/win32/hgwebdir_wsgi.py:*: 'win32traceutil' imported but unused (glob) - setup.py:*: 'sha' imported but unused (glob) - setup.py:*: 'zlib' imported but unused (glob) - setup.py:*: 'bz2' imported but unused (glob) - setup.py:*: 'py2exe' imported but unused (glob) - tests/hghave.py:*: '_lsprof' imported but unused (glob) - tests/hghave.py:*: 'publish_cmdline' imported but unused (glob) - tests/hghave.py:*: 'pygments' imported but unused (glob) - tests/hghave.py:*: 'ssl' imported but unused (glob) - contrib/win32/hgwebdir_wsgi.py:93: 'from isapi.install import *' used; unable to detect undefined names (glob) tests/filterpyflakes.py:58: undefined name 'undefinedname'