# HG changeset patch # User Pierre-Yves David # Date 1431969480 18000 # Node ID 7855d1f5f1521cdb91d7e93dadc6cdb009abbbdb # Parent 4dfd4d3b9b93261ca9d6065ad85277cac6230eeb getlogrevs: rewrite a loop to get read of try/except Get rid of the 'except StopIteration' abomination. diff -r 4dfd4d3b9b93 -r 7855d1f5f152 mercurial/cmdutil.py --- a/mercurial/cmdutil.py Mon May 18 12:17:08 2015 -0500 +++ b/mercurial/cmdutil.py Mon May 18 12:18:00 2015 -0500 @@ -2127,15 +2127,11 @@ if not opts.get('rev'): revs.sort(reverse=True) if limit is not None: - count = 0 limitedrevs = [] - it = iter(revs) - while count < limit: - try: - limitedrevs.append(it.next()) - except (StopIteration): + for idx, r in enumerate(revs): + if limit <= idx: break - count += 1 + limitedrevs.append(r) revs = revset.baseset(limitedrevs) return revs, expr, filematcher