# HG changeset patch # User Kostia Balytskyi # Date 1489191523 28800 # Node ID 7c7d3ad7ca5cb34966e34491153a420fd7acf4f0 # Parent 7485e45807e42019fbfb3a86d46a5867ea6009bc shelve: rename stripnodes to nodestoprune Since we are introducing obs-based shelve, we are no longer stripping temporary nodes, we are obsoleting them. Therefore it looks like stipnodes would be a misleading name, while prune has a connotaion of "strip but with obsolescense", so nodestoprune seems like a good rename. diff -r 7485e45807e4 -r 7c7d3ad7ca5c hgext/shelve.py --- a/hgext/shelve.py Fri Mar 10 15:03:09 2017 -0800 +++ b/hgext/shelve.py Fri Mar 10 16:18:43 2017 -0800 @@ -184,7 +184,7 @@ wctx = nodemod.bin(fp.readline().strip()) pendingctx = nodemod.bin(fp.readline().strip()) parents = [nodemod.bin(h) for h in fp.readline().split()] - stripnodes = [nodemod.bin(h) for h in fp.readline().split()] + nodestoprune = [nodemod.bin(h) for h in fp.readline().split()] branchtorestore = fp.readline().strip() keep = fp.readline().strip() == cls._keep except (ValueError, TypeError) as err: @@ -198,7 +198,7 @@ obj.wctx = repo[wctx] obj.pendingctx = repo[pendingctx] obj.parents = parents - obj.stripnodes = stripnodes + obj.nodestoprune = nodestoprune obj.branchtorestore = branchtorestore obj.keep = keep except error.RepoLookupError as err: @@ -207,7 +207,7 @@ return obj @classmethod - def save(cls, repo, name, originalwctx, pendingctx, stripnodes, + def save(cls, repo, name, originalwctx, pendingctx, nodestoprune, branchtorestore, keep=False): fp = repo.vfs(cls._filename, 'wb') fp.write('%i\n' % cls._version) @@ -217,7 +217,7 @@ fp.write('%s\n' % ' '.join([nodemod.hex(p) for p in repo.dirstate.parents()])) fp.write('%s\n' % - ' '.join([nodemod.hex(n) for n in stripnodes])) + ' '.join([nodemod.hex(n) for n in nodestoprune])) fp.write('%s\n' % branchtorestore) fp.write('%s\n' % (cls._keep if keep else cls._nokeep)) fp.close() @@ -562,7 +562,7 @@ raise mergefiles(ui, repo, state.wctx, state.pendingctx) - repair.strip(ui, repo, state.stripnodes, backup=False, + repair.strip(ui, repo, state.nodestoprune, backup=False, topic='shelve') finally: shelvedstate.clear(repo) @@ -633,12 +633,12 @@ shelvectx = state.pendingctx else: # only strip the shelvectx if the rebase produced it - state.stripnodes.append(shelvectx.node()) + state.nodestoprune.append(shelvectx.node()) mergefiles(ui, repo, state.wctx, shelvectx) restorebranch(ui, repo, state.branchtorestore) - repair.strip(ui, repo, state.stripnodes, backup=False, topic='shelve') + repair.strip(ui, repo, state.nodestoprune, backup=False, topic='shelve') shelvedstate.clear(repo) unshelvecleanup(ui, repo, state.name, opts) ui.status(_("unshelve of '%s' complete\n") % state.name) @@ -690,9 +690,9 @@ except error.InterventionRequired: tr.close() - stripnodes = [repo.changelog.node(rev) - for rev in xrange(oldtiprev, len(repo))] - shelvedstate.save(repo, basename, pctx, tmpwctx, stripnodes, + nodestoprune = [repo.changelog.node(rev) + for rev in xrange(oldtiprev, len(repo))] + shelvedstate.save(repo, basename, pctx, tmpwctx, nodestoprune, branchtorestore, opts.get('keep')) repo.vfs.rename('rebasestate', 'unshelverebasestate')