# HG changeset patch # User Yuya Nishihara # Date 1510320159 -32400 # Node ID 7f8f9f0369cafbd1ead63dfbb50f7f5e28d1a5e5 # Parent 7384250eabd948b5f9b7129d3c5d83c96df350b8 dispatch: extract stub function to peek boolean command option We should at least stop parsing at "--". The 'name' argument is passed for future extension. diff -r 7384250eabd9 -r 7f8f9f0369ca mercurial/dispatch.py --- a/mercurial/dispatch.py Sat Nov 11 12:09:19 2017 +0900 +++ b/mercurial/dispatch.py Fri Nov 10 22:22:39 2017 +0900 @@ -147,7 +147,7 @@ try: if not req.ui: req.ui = uimod.ui.load() - if '--traceback' in req.args: + if _earlyreqoptbool(req, 'traceback', ['--traceback']): req.ui.setconfig('ui', 'traceback', 'on', '--traceback') # set ui streams from the request @@ -275,7 +275,7 @@ if not debugger or ui.plain(): # if we are in HGPLAIN mode, then disable custom debugging debugger = 'pdb' - elif '--debugger' in req.args: + elif _earlyreqoptbool(req, 'debugger', ['--debugger']): # This import can be slow for fancy debuggers, so only # do it when absolutely necessary, i.e. when actual # debugging has been requested @@ -289,7 +289,7 @@ debugmortem[debugger] = debugmod.post_mortem # enter the debugger before command execution - if '--debugger' in req.args: + if _earlyreqoptbool(req, 'debugger', ['--debugger']): ui.warn(_("entering debugger - " "type c to continue starting hg or h for help\n")) @@ -305,7 +305,7 @@ ui.flush() except: # re-raises # enter the debugger when we hit an exception - if '--debugger' in req.args: + if _earlyreqoptbool(req, 'debugger', ['--debugger']): traceback.print_exc() debugmortem[debugger](sys.exc_info()[2]) raise @@ -698,6 +698,10 @@ pos += 1 return values +def _earlyreqoptbool(req, name, aliases): + assert len(aliases) == 1 + return aliases[0] in req.args + def runcommand(lui, repo, cmd, fullargs, ui, options, d, cmdpats, cmdoptions): # run pre-hook, and abort if it fails hook.hook(lui, repo, "pre-%s" % cmd, True, args=" ".join(fullargs), @@ -785,7 +789,7 @@ if req.repo: uis.add(req.repo.ui) - if '--profile' in args: + if _earlyreqoptbool(req, 'profile', ['--profile']): for ui_ in uis: ui_.setconfig('profiling', 'enabled', 'true', '--profile')