# HG changeset patch # User David Soria Parra # Date 1300132435 -3600 # Node ID 80d6e1f63ed9585fb6afa718cca786c2b19ae847 # Parent ee349e228835812adf97b0e52222792865404388 localrepo: do not update bookmarks in addchangegroup We want to update the current bookmark to the most recent revision on current branch unless there is a remote bookmark that points to a different descendant. Addchangegroup is called before we can check for remote bookmarks. We don't update the bookmark in addchangegroup anymore to allow proper updating of bookmarks in pull. diff -r ee349e228835 -r 80d6e1f63ed9 mercurial/localrepo.py --- a/mercurial/localrepo.py Tue Mar 15 18:33:36 2011 +0100 +++ b/mercurial/localrepo.py Mon Mar 14 20:53:55 2011 +0100 @@ -1894,10 +1894,6 @@ self.hook("incoming", node=hex(cl.node(i)), source=srctype, url=url) - # FIXME - why does this care about tip? - if newheads == oldheads: - bookmarks.update(self, self.dirstate.parents(), self['tip'].node()) - # never return 0 here: if newheads < oldheads: return newheads - oldheads - 1 diff -r ee349e228835 -r 80d6e1f63ed9 tests/test-bookmarks-pushpull.t --- a/tests/test-bookmarks-pushpull.t Tue Mar 15 18:33:36 2011 +0100 +++ b/tests/test-bookmarks-pushpull.t Mon Mar 14 20:53:55 2011 +0100 @@ -26,6 +26,7 @@ adding manifests adding file changes added 1 changesets with 1 changes to 1 files + updating bookmark Y (run 'hg update' to get a working copy) $ hg bookmarks Y 0:4e3505fd9583